Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

csv_validator: add check to ensure that the example is a valid JSON #207

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Dec 12, 2021

Description
csv_validator: add a check to ensure that the example is a valid JSON.
Note that when it fails we are pointing out where is the issue as well.

Motivation
Closes: #116
Closes: #115

@openshift-ci openshift-ci bot requested review from estroz and njhale December 12, 2021 09:20
@camilamacedo86 camilamacedo86 changed the title csv validator: add test to ensure that examples are checked csv_validator: add check to ensure that the example is a valid JSON Dec 12, 2021
@camilamacedo86
Copy link
Contributor Author

c/c @gallettilance @mvalarh @J0zi

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2022
@camilamacedo86
Copy link
Contributor Author

@gallettilance could you give a hand with this one?

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alm-examples json validation
3 participants