Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alm-example parse check should not fail when the annotation if empty #215

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jan 15, 2022

Description
Fix error found using the check to test the images data.
Error "Error: Value invalid character at 0\n \u003c--(see the invalid character): invalid example" is faced when the alm-example is empty and should not.

Follow up: #207

@camilamacedo86
Copy link
Contributor Author

@dinhxuanvu, could you please give to us a hand on in this one?

@dinhxuanvu
Copy link
Member

I'm a bit confused here. I only see a yaml file. Where are the codes?

@camilamacedo86
Copy link
Contributor Author

Hi @dinhxuanvu,

Sorry, I did not push the full commit. All done now.
Could you please help us get this small fix/nit get merged?

@dinhxuanvu
Copy link
Member

dinhxuanvu commented Jan 17, 2022

@camilamacedo86 No worries. Can you do me a favor and strip out anything that is not needed in the CSV yaml to reduce its size if possible?

@camilamacedo86
Copy link
Contributor Author

@dinhxuanvu, done 👍

Copy link
Member

@dinhxuanvu dinhxuanvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2022
@dinhxuanvu
Copy link
Member

/approve

@openshift-ci
Copy link

openshift-ci bot commented Jan 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, dinhxuanvu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit 77b3984 into operator-framework:master Jan 17, 2022
@camilamacedo86 camilamacedo86 deleted the fix-example-check branch January 17, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants