-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: alm-example parse check should not fail when the annotation if empty #215
fix: alm-example parse check should not fail when the annotation if empty #215
Conversation
@dinhxuanvu, could you please give to us a hand on in this one? |
I'm a bit confused here. I only see a yaml file. Where are the codes? |
Hi @dinhxuanvu, Sorry, I did not push the full commit. All done now. |
@camilamacedo86 No worries. Can you do me a favor and strip out anything that is not needed in the CSV yaml to reduce its size if possible? |
@dinhxuanvu, done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Fix error found using the check to test the images data.
Error
"Error: Value invalid character at 0\n \u003c--(see the invalid character): invalid example"
is faced when the alm-example is empty and should not.Follow up: #207