(bugfix): add label selector to sync list queries #112
Conversation
to prevent overwriting of resources not belonging to the Catalog currently being reconciled Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Codecov Report
@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 78.11% 79.62% +1.50%
==========================================
Files 1 1
Lines 265 265
==========================================
+ Hits 207 211 +4
+ Misses 37 33 -4
Partials 21 21
|
|
WDYT about adding/updating tests to cover this and make sure we don't regress this behavior? |
and update them slightly as it seemed like the feature gates were not appropriately enabled resulting in tests not running Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
| Expect(res).To(Equal(ctrl.Result{})) | ||
| Expect(err).ToNot(HaveOccurred()) | ||
|
|
||
| expectedCm := &v1alpha1.CatalogMetadata{} |
There was a problem hiding this comment.
I wonder if directly creating the Package/BundleMetadata/CatalogMetadata, running the other catalog's reconcile, and then checking that this still exists is brittle? If we change the label selector we use we'd invalidate this test.
What about instead, just creating two different Catalog objects (they can ref the same image), reconcile both of them, and then check that all expected Package/BundleMetadata/CatalogMetadata are present?
There was a problem hiding this comment.
Ah, that's a good point - I'll take a look into this
There was a problem hiding this comment.
done across a couple commits but should be good to go
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
instead of creating an indivdual resource. Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
|
/cherrypick release-v0.4 |
|
@everettraven: new pull request created: #123 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
prevents overwriting of resources not belonging to the Catalog currently being reconciled
closes #106