Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v0.4] (bugfix): add label selector to sync list queries #123

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #112

/assign everettraven

to prevent overwriting of resources not belonging to the Catalog
currently being reconciled

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
and update them slightly as it seemed like the feature gates
were not appropriately enabled resulting in tests not running

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
instead of creating an indivdual resource.

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #123 (098fbaa) into release-v0.4 (3b1780e) will increase coverage by 1.50%.
The diff coverage is 0.00%.

@@               Coverage Diff                @@
##           release-v0.4     #123      +/-   ##
================================================
+ Coverage         78.11%   79.62%   +1.50%     
================================================
  Files                 1        1              
  Lines               265      265              
================================================
+ Hits                207      211       +4     
+ Misses               37       33       -4     
  Partials             21       21              
Impacted Files Coverage Δ
pkg/controllers/core/catalog_controller.go 79.62% <0.00%> (+1.50%) ⬆️

@everettraven everettraven merged commit 969f178 into operator-framework:release-v0.4 Jul 18, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants