Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v0.4] (bugfix): add label selector to sync list queries #123

Merged
merged 7 commits into from
Jul 18, 2023
Merged

[release-v0.4] (bugfix): add label selector to sync list queries #123

merged 7 commits into from
Jul 18, 2023

Commits on Jul 18, 2023

  1. add label selector to sync list queries 

    to prevent overwriting of resources not belonging to the Catalog
currently being reconciled

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven authored and openshift-cherrypick-robot committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    eaca4f4 View commit details
    Browse the repository at this point in the history

  2. add unit test 

    and update them slightly as it seemed like the feature gates
were not appropriately enabled resulting in tests not running

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven authored and openshift-cherrypick-robot committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    617174a View commit details
    Browse the repository at this point in the history

  3. fix lint issues 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven authored and openshift-cherrypick-robot committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    d0be287 View commit details
    Browse the repository at this point in the history

  4. harden the sync test case by using multiple catalogs 

    instead of creating an indivdual resource.

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven authored and openshift-cherrypick-robot committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    0434e04 View commit details
    Browse the repository at this point in the history

  5. clean up test implementation 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven authored and openshift-cherrypick-robot committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    f6fe216 View commit details
    Browse the repository at this point in the history

  6. address review comments 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven authored and openshift-cherrypick-robot committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    7b408ef View commit details
    Browse the repository at this point in the history

  7. remove all label len checks 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven authored and openshift-cherrypick-robot committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    098fbaa View commit details
    Browse the repository at this point in the history