Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Package and BundleMetadata APIs #149

Merged

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Aug 28, 2023

Our most recent release syncs to both Package/BundleMetadata APIs and to CatalogMetadata API. As of operator-framework/operator-controller#343, operator-controller no longer has a dependency on the Package/BundleMetadata APIs.

I suggest we remove the Package and BundleMetadata APIs now since they are no longer in use by any known clients.

@joelanford joelanford requested a review from a team as a code owner August 28, 2023 21:07
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #149 (4d88c69) into main (a8f7196) will increase coverage by 1.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   78.01%   79.61%   +1.60%     
==========================================
  Files           2        2              
  Lines         282      157     -125     
==========================================
- Hits          220      125      -95     
+ Misses         39       20      -19     
+ Partials       23       12      -11     
Files Changed Coverage Δ
pkg/controllers/core/catalog_controller.go 79.35% <ø> (+1.49%) ⬆️

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford force-pushed the drop-packagebundlemetadataapis branch from d667c9b to 4d88c69 Compare August 28, 2023 22:57
@joelanford joelanford added this to the v0.6.0 milestone Aug 29, 2023
@joelanford joelanford added this pull request to the merge queue Aug 29, 2023
Merged via the queue into operator-framework:main with commit 8aab690 Aug 29, 2023
9 checks passed
@joelanford joelanford deleted the drop-packagebundlemetadataapis branch August 29, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants