Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all references to the old catalogd Package and BundleMetadata APIs #372

Conversation

joelanford
Copy link
Member

Description

This follows up on #343 to remove the final bits of references to the catalogd Package and BundleMetadata APIs. This is important if we want Operator Controller to be able to bump to a version of Catalogd that removes those APIs.

See operator-framework/catalogd#149

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

…undleMetadata APIs

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner August 29, 2023 14:57
Copy link
Contributor

@dtfranz dtfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@joelanford joelanford added this pull request to the merge queue Aug 29, 2023
@joelanford joelanford added this to the v0.5.0 milestone Aug 29, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2023
@joelanford joelanford added this pull request to the merge queue Aug 29, 2023
@joelanford joelanford removed this pull request from the merge queue due to a manual request Aug 29, 2023
@joelanford
Copy link
Member Author

Investigating apparent flakes and/or failures that occurred in the merge queue CI...

@joelanford
Copy link
Member Author

go-apidiff failure will be covered by #373
the e2e-kind error seems like a flake that was not introduced by this PR.

Re-adding to merge queue.

@joelanford joelanford added this pull request to the merge queue Aug 29, 2023
Merged via the queue into operator-framework:main with commit db08a62 Aug 29, 2023
9 checks passed
@joelanford joelanford deleted the catalogd-packagebundlemetadata-final-cleanup branch June 20, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants