Remove go-apidiff GHA from merge_group runs #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #373 +/- ##
==========================================
+ Coverage 81.46% 82.11% +0.64%
==========================================
Files 21 21
Lines 928 928
==========================================
+ Hits 756 762 +6
+ Misses 119 116 -3
+ Partials 53 50 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
go-apidiff is meant to be informational and is optional, so it will not block PRs in the merge queue, even when it finds incompatible changes. Therefore it serves no real purpose in the merge queue CI. There also seems to be an issue with running go-apidiff in the context of a merge_queue where it fails due to invalid commit references. For these reasons, removing it from the merge queue CI Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
rm-go-apidiff-merge-queue
branch
from
1a34a3c
to
7ceb13a
Compare
ncdc
approved these changes
Aug 29, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
go-apidiff is meant to be informational and is optional, so it will not block PRs in the merge queue, even when it finds incompatible changes. Therefore it serves no real purpose in the merge queue CI.
There also seems to be an issue with running go-apidiff in the context of a merge_queue where it fails due to invalid commit references. See https://github.com/operator-framework/operator-controller/actions/runs/6014708335/job/16315430191
For these reasons, removing it from the merge queue CI
Reviewer Checklist