Skip to content

Commit

Permalink
Remove go-apidiff GHA from merge_group runs (#373)
Browse files Browse the repository at this point in the history
go-apidiff is meant to be informational and is optional, so it will not block PRs in the merge queue, even when it finds incompatible changes. Therefore it serves no real purpose in the merge queue CI.

There also seems to be an issue with running go-apidiff in the context of a merge_queue where it fails due to invalid commit references.

For these reasons, removing it from the merge queue CI

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
  • Loading branch information
joelanford committed Aug 29, 2023
1 parent 2114da6 commit 9d07bb1
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/go-apidiff.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
name: go-apidiff
on:
pull_request:
merge_group:
jobs:
go-apidiff:
runs-on: ubuntu-latest
Expand Down

0 comments on commit 9d07bb1

Please sign in to comment.