Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove go-apidiff GHA from merge_group runs #373

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Remove go-apidiff GHA from merge_group runs #373

merged 1 commit into from
Aug 29, 2023

Commits on Aug 29, 2023

  1. Remove go-apidiff GHA from merge_group runs 

    go-apidiff is meant to be informational and is optional, so it will not block PRs in the merge queue, even when it finds incompatible changes. Therefore it serves no real purpose in the merge queue CI.

There also seems to be an issue with running go-apidiff in the context of a merge_queue where it fails due to invalid commit references.

For these reasons, removing it from the merge queue CI

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
    @joelanford
    joelanford committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    7ceb13a View commit details
    Browse the repository at this point in the history