Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 bump supported k8s version to 1.28 #227

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

everettraven
Copy link
Collaborator

Description

  • bumps controller-runtime --> v0.16.3
  • bumps k8s.io deps --> v0.28.5
  • bumps operator-registry --> v1.34.0
  • updated kind version --> v0.20.0
  • made kind node image configurable and 1.28 by default updated ginkgo version --> v2.12.0
  • removes profile package in favor of using the controller-runtime default pprof configuration options

Motivation

@everettraven everettraven requested a review from a team as a code owner January 11, 2024 21:15
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2024
@everettraven everettraven changed the title 🌱 (chore): bump supported k8s version to 1.28 🌱 bump supported k8s version to 1.28 Jan 11, 2024
bumps controller-runtime --> v0.16.3
bumps k8s.io deps --> v0.28.5
bumps operator-registry --> v1.34.0
updated kind version --> v0.20.0
made kind node image configurable and 1.28 by default
updated ginkgo version --> v2.12.0

Signed-off-by: everettraven <everettraven@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 11, 2024
Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (4d2ea6a) 39.58% compared to head (c8917c4) 39.83%.

Files Patch % Lines
cmd/manager/main.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
+ Coverage   39.58%   39.83%   +0.24%     
==========================================
  Files           8        8              
  Lines         485      482       -3     
==========================================
  Hits          192      192              
+ Misses        272      269       -3     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven
Copy link
Collaborator Author

apidiff failure is expected due to the profile package removal

@everettraven everettraven added this pull request to the merge queue Jan 11, 2024
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2024
Merged via the queue into operator-framework:main with commit 0e0ebc3 Jan 11, 2024
11 of 13 checks passed
@everettraven everettraven deleted the chore/bump-k8s branch January 11, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump k8s to 1.28
4 participants