Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: build targets use go build directly #85

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Conversation

joelanford
Copy link
Member

Remove the goreleaser dependency of the make build target, and modify the Makefile and .goreleaser.yml to use a consistent build configuration.

Split the build into build-deps and go-build-local (and make similar changes for build-linux. This keeps the existing
overall functionality, but splits out the actual go builds into separate targets which are useful if you know your repo is up-to-date and you want to build without requiring extra build dependencies (e.g. controller-gen and goreleaser)

See operator-framework/operator-controller#253

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Copy link
Member

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2023
@joelanford joelanford merged commit aef2057 into main Jun 7, 2023
@joelanford joelanford deleted the go-build branch June 7, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants