Makefile: build targets use go build directly #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
approved these changes
Jun 6, 2023
grokspawn
reviewed
Jun 6, 2023
joelanford
force-pushed
the
go-build
branch
3 times, most recently
from
2bc81d4
to
8c922b9
Compare
|
EDIT: Figured it out. I needed |
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
grokspawn
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the goreleaser dependency of the
make buildtarget, and modify theMakefileand.goreleaser.ymlto use a consistent build configuration.Split the
buildintobuild-depsandgo-build-local(and make similar changes forbuild-linux. This keeps the existingoverall functionality, but splits out the actual go builds into separate targets which are useful if you know your repo is up-to-date and you want to build without requiring extra build dependencies (e.g. controller-gen and goreleaser)
Reviewer Checklist