Golangci lint upgrade #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
m1kola
commented
Jun 16, 2023
| @@ -6,7 +6,6 @@ linters: | |||
| enable: | |||
| - asciicheck | |||
| - bodyclose | |||
| - depguard | |||
There was a problem hiding this comment.
depguard linter removed. We do not have configuration for it and new version of golangci-lint comes with the configuration where only Go standard library is allowed.
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
force-pushed
the
golangci-lint-upgrade
branch
from
8393307
to
8f163c8
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Merged
ncdc
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #103 which needs to be merged first