Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes return error from NewDeppySolver #98

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Removes return error from NewDeppySolver #98

merged 1 commit into from
Jun 2, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jun 1, 2023

This PR removes return error from NewDeppySolver as It never returns one.

@m1kola
Removes return error from NewDeppySolver
e2ea021 
It never returns an error

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola requested a review from a team as a code owner June 1, 2023 12:53
stevekuznetsov
stevekuznetsov approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@stevekuznetsov stevekuznetsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
perdasilva
perdasilva approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@perdasilva perdasilva merged commit cbf2c66 into operator-framework:main Jun 2, 2023
@m1kola m1kola deleted the NewDeppySolver_remove_err branch June 2, 2023 12:08
@m1kola m1kola mentioned this pull request Jun 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perdasilva perdasilva perdasilva approved these changes

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

@everettraven everettraven everettraven approved these changes

Assignees

@stevekuznetsov stevekuznetsov

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m1kola @perdasilva @stevekuznetsov @everettraven