Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates deppy #249

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Updates deppy #249

merged 1 commit into from
Jun 2, 2023

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jun 2, 2023

Description

Bumps deppy to the latest commit in master.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2023
@m1kola
Updates deppy
313bd47 
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola marked this pull request as ready for review June 2, 2023 12:41
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2023
@m1kola m1kola requested review from perdasilva and anik120 June 2, 2023 12:41
varshaprasad96
varshaprasad96 approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I missed the change where removed returning error from NewDeppySolver.

Else it looks good to me!
/lgtm

internal/resolution/variable_sources/olm/olm_test.go
func (f FailEntitySource) Get(ctx context.Context, id deppy.Identifier) *input.Entity {
return nil
func (f FailEntitySource) Get(ctx context.Context, id deppy.Identifier) (*input.Entity, error) {
return nil, fmt.Errorf("error executing get")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker at all: but do we want to define this as constants?
panicEntitySrcErr, FailEntitySrcErr etc.. just in case we want to use it in tests to assert the errors.

Copy link
Member Author

@m1kola m1kola Jun 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how it might be useful, but I would like to avoid doing it in this PR. Focus of this is to upgrade Deppy with minimal changes to operator controller.

This function follows the existing pattern (see Filter, GroupBy, etc below).

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2023
@m1kola
Copy link
Member Author

m1kola commented Jun 2, 2023

I think I missed the change where removed returning error from NewDeppySolver.

I removed error from the return types in this PR since NewDeppySolver always returns nil. I suspect that some time ago there was a branch in NewDeppySolver which was returning an error, but it no longer exists.

@m1kola m1kola merged commit 35f381d into operator-framework:main Jun 2, 2023
5 checks passed
@m1kola m1kola deleted the bump_deppy branch June 2, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@perdasilva perdasilva Awaiting requested review from perdasilva

@anik120 anik120 Awaiting requested review from anik120

Assignees

@varshaprasad96 varshaprasad96

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@m1kola @everettraven @varshaprasad96