Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to watch List object types #138

Conversation

varshaprasad96
Copy link
Member

This commit modifies dependentResourceWatcher to
accept List kinds while watching dependent resources.
It also adds test to verify if setWatchOnResource
works for lists.

Reference: operator-framework/operator-sdk#4682

Signed-off-by: varshaprasad96 varshaprasad96@gmail.com
Closes: #89

This commit modifies `dependentResourceWatcher` to
accept `List` kinds while watching dependent resources.
It also adds test to verify if `setWatchOnResource`
works for lists.

Reference: operator-framework/operator-sdk#4682

Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1532265509

  • 34 of 40 (85.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 62.216%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/reconciler/internal/hook/hook.go 34 40 85.0%
Files with Coverage Reduction New Missed Lines %
pkg/reconciler/internal/hook/hook.go 1 89.86%
Totals Coverage Status
Change from base Build 1476478121: 0.2%
Covered Lines: 1696
Relevant Lines: 2726

💛 - Coveralls

@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2021
@varshaprasad96 varshaprasad96 merged commit de4f99a into operator-framework:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sdk area/testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly handle watch creation for List object contents
3 participants