fix(Helm.controller.watch): Process watch for List kind #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
reviewed
Mar 18, 2021
|
Additionally can you add a changelog entry for this bugfix? /kind bug |
openshift-ci-robot
added
the
kind/bug
hickeyma
force-pushed
the
fix/handle-list-in-watch
branch
from
c7032c4
to
9644086
Compare
hickeyma
force-pushed
the
fix/handle-list-in-watch
branch
from
9644086
to
1c08bd0
Compare
hickeyma
force-pushed
the
fix/handle-list-in-watch
branch
from
1c08bd0
to
d94b828
Compare
|
Thanks fo the review @estroz. I have updated with your feedback and it is ready to review again. BTW, does this need a changelog? |
Yep! |
hickeyma
force-pushed
the
fix/handle-list-in-watch
branch
from
d94b828
to
7ec5eaf
Compare
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
hickeyma
force-pushed
the
fix/handle-list-in-watch
branch
from
7ec5eaf
to
d8eae7c
Compare
|
@estroz Changelog added. |
estroz
approved these changes
Mar 18, 2021
|
Thanks for reviews and merge @estroz |
varshaprasad96
added a commit
to varshaprasad96/helm-operator-plugins
that referenced
this pull request
Dec 2, 2021
This commit modifies `dependentResourceWatcher` to accept `List` kinds while watching dependent resources. It also adds test to verify if `setWatchOnResource` works for lists. Reference: operator-framework/operator-sdk#4682 Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
varshaprasad96
added a commit
to operator-framework/helm-operator-plugins
that referenced
this pull request
Dec 6, 2021
This commit modifies `dependentResourceWatcher` to accept `List` kinds while watching dependent resources. It also adds test to verify if `setWatchOnResource` works for lists. Reference: operator-framework/operator-sdk#4682 Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
The Kubernetes
kind: Listis not actually a resource and therefore cannot have a watch set on it. This PR iterates on theListitems instead and sets the watch on those Kubernetes kinds.Motivation for the change:
Helm operator controller errors out when a Helm chart has a
kind: Listdeclared.Closes #4636
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs