-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Helm.controller.watch): Process watch for List kind #4682
fix(Helm.controller.watch): Process watch for List kind #4682
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits and a suggested fix. Otherwise LGTM. Thanks @hickeyma!
Additionally can you add a changelog entry for this bugfix? /kind bug |
c7032c4
to
9644086
Compare
9644086
to
1c08bd0
Compare
1c08bd0
to
d94b828
Compare
Thanks fo the review @estroz. I have updated with your feedback and it is ready to review again. BTW, does this need a changelog? |
Yep! |
d94b828
to
7ec5eaf
Compare
Signed-off-by: Martin Hickey <martin.hickey@ie.ibm.com>
7ec5eaf
to
d8eae7c
Compare
@estroz Changelog added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @hickeyma
/lgtm
Thanks for reviews and merge @estroz |
This commit modifies `dependentResourceWatcher` to accept `List` kinds while watching dependent resources. It also adds test to verify if `setWatchOnResource` works for lists. Reference: operator-framework/operator-sdk#4682 Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
This commit modifies `dependentResourceWatcher` to accept `List` kinds while watching dependent resources. It also adds test to verify if `setWatchOnResource` works for lists. Reference: operator-framework/operator-sdk#4682 Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
Description of the change:
The Kubernetes
kind: List
is not actually a resource and therefore cannot have a watch set on it. This PR iterates on theList
items instead and sets the watch on those Kubernetes kinds.Motivation for the change:
Helm operator controller errors out when a Helm chart has a
kind: List
declared.Closes #4636
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs