Expose generic mechanism for configuring the controller builder #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
mtesseract
force-pushed
the
mc/extra-watches
branch
from
7c1a306
to
095f0ae
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
mtesseract
force-pushed
the
mc/extra-watches
branch
4 times, most recently
from
872d19c
to
80d57ba
Compare
Pull Request Test Coverage Report for Build 2260291688
💛 - Coveralls |
openshift-ci
bot
added
the
needs-rebase
…add additional watch sources. Signed-off-by: Moritz Clasmeier <moritz@stackrox.com>
mtesseract
force-pushed
the
mc/extra-watches
branch
from
80d57ba
to
7875e85
Compare
openshift-ci
bot
removed
the
needs-rebase
|
PR rebased. |
varshaprasad96
approved these changes
Apr 12, 2022
|
Is the CI failure caused by the linter something that needs to be fixed in this PR? |
|
@mtesseract I fixed the lint CI failure in #161 I'll close and re-open this PR so that the new commits on |
|
Thanks. |
|
Any update on this? Thanks. |
|
@varshaprasad96 can this be merged ? |
|
Hello code owners! @joelanford @varshaprasad96 @camilamacedo86 @everettraven @fabianvf Would it be possible to merge this PR? We have an issue that has been lingering in our backlog to track this, and we would feel extra good to be able to close this off! Thank you again |
|
@ludydoo @mtesseract Apologies for missing this. This does seems to be good to go. |
varshaprasad96
added a commit
to varshaprasad96/helm-operator-plugins
that referenced
this pull request
Jul 27, 2023
Merging operator-framework#153 broke main since it was using an plder version of controller-runtime. This commit fixes the same. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
varshaprasad96
added a commit
that referenced
this pull request
Jul 28, 2023
Merging #153 broke main since it was using an plder version of controller-runtime. This commit fixes the same. Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose generic mechanism for configuring the controller, allowing to add additional watch sources.
Signed-off-by: Moritz Clasmeier moritz@stackrox.com