-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistently use go 1.17 throughout repository #161
consistently use go 1.17 throughout repository #161
Conversation
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
Pull Request Test Coverage Report for Build 2260072380
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit on the actions.
.github/workflows/ci.yml
Outdated
with: | ||
go-version: ~1.17 | ||
id: go | ||
|
||
- name: Check out code into the Go module directory | ||
uses: actions/checkout@v2 | ||
|
||
- name: Lint | ||
uses: golangci/golangci-lint-action@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we were to update to golangci/golangci-lint-action@v3
it would use the existing installed go version that was setup with the actions/setup-go@v2
I think it may be worth it to upgrade this so that we wouldn't have to handle updating the with.version
. What do you think?
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Joe Lanford joe.lanford@gmail.com