Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated v1alpha scaffolding #191

Merged
merged 5 commits into from
Aug 10, 2022
Merged

updated v1alpha scaffolding #191

merged 5 commits into from
Aug 10, 2022

Conversation

laxmikantbpandhare
Copy link
Member

This will fix #188

@laxmikantbpandhare laxmikantbpandhare self-assigned this Aug 8, 2022
everettraven
everettraven requested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor typo in the docs. Other than that looks good to me.

docs/tutorial.md Outdated Show resolved Hide resolved
@varshaprasad96
Copy link
Member

varshaprasad96 commented Aug 9, 2022 •
edited
Loading

@laxmikantbpandhare there seems to be something wrong where you are replacing the chunk of code. Refer to CI error: error updating kustomization.yaml files: remove config/default/kustomization.yaml patch and vars blocks: unable to find the content to be replaced\n"

@laxmikantbpandhare
Copy link
Member Author

@laxmikantbpandhare there seems to be something wrong where you are replacing the chunk of code. Refer to CI error: error updating kustomization.yaml files: remove config/default/kustomization.yaml patch and vars blocks: unable to find the content to be replaced\n"

@varshaprasad96 - there is something missing in testdata. I am looking into it. I did not get time.

@laxmikantbpandhare
Copy link
Member Author

laxmikantbpandhare commented Aug 9, 2022 •
edited
Loading

SDK is not updated yet with v2alpha that's why hybrid helm plugins are still scaffolding files with kustomizev1. Once this PR gets merged and hybrid helm points to the latest commit then there will be no issue at all on the hybrid-helm-plugins side.

@coveralls
Copy link

coveralls commented Aug 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2828774309

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.286%
Totals Coverage Status
Change from base Build 2805375666: 0.0%
Covered Lines: 1575
Relevant Lines: 1764
💛 - Coveralls

@camilamacedo86 camilamacedo86 mentioned this pull request Aug 10, 2022
Merged
varshaprasad96
varshaprasad96 approved these changes Aug 10, 2022
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

camilamacedo86
camilamacedo86 approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2022
@laxmikantbpandhare laxmikantbpandhare merged commit 98def35 into operator-framework:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camilamacedo86 camilamacedo86 camilamacedo86 approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

@porridge porridge Awaiting requested review from porridge

@everettraven everettraven Awaiting requested review from everettraven

Assignees

@camilamacedo86 camilamacedo86

@varshaprasad96 varshaprasad96

@laxmikantbpandhare laxmikantbpandhare

Labels
area/sdk area/testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hybrid is missing config for cert-manager and webhooks
5 participants
@laxmikantbpandhare @varshaprasad96 @coveralls @camilamacedo86 @everettraven