Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubebuilder release 3.6.0, upgrade kustomize and add support for Apple Silicon #5965

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Aug 3, 2022

Description

Bump kubebuilder, upgrade kustomize and add support to Apple Silicon

Changes:

  • Add a plugin (deploy-image/v1-alpha)
  • Add a plugin (grafana/v1-alpha)
  • Add new golang plugin go/v4-alpha which adds support for Apple Silicon(darwin/arm64)
  • Fix Makefile targets to not download binaries when they are found already
  • Remove the option to call kustomize/v1 plugin alone. If you are looking to use this project as a base for you to generate other plugins, please use Kubebuilder instead.
  • description: (go/v3) Update controller-tools from 0.9.0 to 0.9.2. More info
  • (go/v3) Update controller-tools from 0.9.0 to 0.9.2.
  • (go/v3) Update controller-runtime from v0.12.1 to v0.12.2 and Kubernetes dependencies from v0.24.0 to v0.24.2. More info
  • (go/v3,ansible/v1,helm/v1) Update gcr.io/kubebuilder/kube-rbac-proxy from 0.12.0 to 0.13.0. More info
  • (ansible/v1,helm/v1) Add supports for Apple Silicon(darwin/arm64) and upgrade kustomize version from v3.8.7 to v4.5.5. Release Notes
  • Remove the sample for go/v2 since it is no longer the default scaffold for more than 1 year and should no longer be used. It is deprecated.
  • Add samples testdatda for go/v4-alpha

@camilamacedo86 camilamacedo86 changed the title Bump kubebuilder, upgrade kustomize and add support to Apple Silicon WIP: Bump kubebuilder, upgrade kustomize and add support to Apple Silicon Aug 3, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@jmrodri jmrodri changed the title WIP: Bump kubebuilder, upgrade kustomize and add support to Apple Silicon WIP: Bump kubebuilder, upgrade kustomize and add support for Apple Silicon Aug 3, 2022
@camilamacedo86 camilamacedo86 changed the title WIP: Bump kubebuilder, upgrade kustomize and add support for Apple Silicon Bump kubebuilder release 3.6.0, upgrade kustomize and add support for Apple Silicon Aug 3, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2022
@camilamacedo86 camilamacedo86 force-pushed the bump-kb-kustom branch 3 times, most recently from d49f112 to efce93e Compare August 6, 2022 14:05
@camilamacedo86 camilamacedo86 added release-blocker This issue blocks the parent release milestone and removed release-blocker This issue blocks the parent release milestone labels Aug 6, 2022
go.mod Show resolved Hide resolved
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits, and a question. Else lgtm from me.

changelog/fragments/bump-kubebuilder-add-kustomize.yaml Outdated Show resolved Hide resolved
changelog/fragments/bump-kubebuilder-add-kustomize.yaml Outdated Show resolved Hide resolved
changelog/fragments/bump-kubebuilder-add-kustomize.yaml Outdated Show resolved Hide resolved
changelog/fragments/bump-kubebuilder-add-kustomize.yaml Outdated Show resolved Hide resolved
changelog/fragments/bump-kubebuilder-add-kustomize.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concur with @varshaprasad96 review. The rest looks okay to me.

@camilamacedo86 camilamacedo86 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 11, 2022
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just nits.
/lgtm

changelog/fragments/bump-kubebuilder-add-kustomize.yaml Outdated Show resolved Hide resolved
changelog/fragments/bump-kubebuilder-add-kustomize.yaml Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022
Co-authored-by: Varsha <varshaprasad96@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022
Co-authored-by: Varsha <varshaprasad96@gmail.com>
Copy link
Member

@laxmikantbpandhare laxmikantbpandhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2022
@jmrodri jmrodri merged commit afc3a88 into operator-framework:master Aug 11, 2022
@camilamacedo86 camilamacedo86 deleted the bump-kb-kustom branch August 13, 2022 19:12
dacamposol pushed a commit to dacamposol/operator-sdk that referenced this pull request Oct 6, 2022
… Apple Silicon (operator-framework#5965)

* Bump kubebuilder 3.6.0, upgrade kustomize and add support to Apple Silicon
* Update changelog/fragments/bump-kubebuilder-add-kustomize.yaml
* Update changelog/fragments/bump-kubebuilder-add-kustomize.yaml

Co-authored-by: Varsha <varshaprasad96@gmail.com>
Signed-off-by: Daniel Campos Olivares <daniel.campos.olivares@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants