-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing parameter in hook watch #235
Fix missing parameter in hook watch #235
Conversation
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juldrixx would you mind separating this into 2 PRs? One for the hook watch fix and one for the Go 1.21 bump? We tend to be more cautious when doing a Go bump as it can negatively impact projects that depend on this repository but might not be able to bump Go yet
Sure |
New changes are detected. LGTM label has been removed. |
#216 updated the
dependentResourceWatcher
struct to add thecache
and thescheme
, but did not initialize them even though they were passed on to creation.The
cache
is therefore empty and the code crashs on here.