Bump controller-runtime and k8s.io deps #216
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
This change bumps controller-runtime to 0.15 and k8s.io/* deps to 0.27.2 Signed-off-by: Brendan Shephard <bshephar@redhat.com>
bshephar
force-pushed
the
controller-runtime
branch
from
7adc05f to
8595064
Compare
bshephar
force-pushed
the
controller-runtime
branch
4 times, most recently
from
67948b5 to
6410ccf
Compare
This commit contains: 1. Bumping and pinning of right dependencies 2. Remove Delegating client 3. Fixing NewDynamicRestMapper func signature 4. Fix cmd/ to not take client as an option 5. Use go/v4 instead of v3 Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
…ecks Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
bshephar
force-pushed
the
controller-runtime
branch
from
505383e to
85653be
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
bshephar
force-pushed
the
controller-runtime
branch
2 times, most recently
from
f4afaa9 to
5e09267
Compare
There was a problem hiding this comment.
@bshephar could you run make generate again and commit the changes. Looks like CI is failing for sanity checks: https://github.com/operator-framework/helm-operator-plugins/actions/runs/5481106188/jobs/9998233497?pr=216#step:8:1
bshephar
force-pushed
the
controller-runtime
branch
from
5e09267 to
33ca8a4
Compare
|
@bshephar @everettraven @varshaprasad96 looks like the sanity test is failing. It looks like the go.mod isn't matching. Might be a difference between authors version of go and the one used in CI or something else. This needs to be addressed to avoid issues in other PRs. The go-apidiff is okay and expected. |
Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
bshephar
force-pushed
the
controller-runtime
branch
from
063f554 to
5c7c077
Compare
There was a problem hiding this comment.
@bshephar could you bump golangci-lint to 1.51.2 at these places:
This should fix the issues with CI. In hindsight, we should remove the separate CI run that runs linter again, as that is anyway done as a part of test action.
If that is addressed, I think the PR should be good to go.
bshephar
force-pushed
the
controller-runtime
branch
2 times, most recently
from
222ba73 to
d7cb9ff
Compare
This change bumps controller-runtime to 0.15 and k8s.io/* deps to 0.27.2 Signed-off-by: Brendan Shephard <bshephar@redhat.com>
bshephar
force-pushed
the
controller-runtime
branch
from
d7cb9ff to
724035b
Compare
|
/override go-apidiff |
|
@varshaprasad96: Overrode contexts on behalf of varshaprasad96: go-apidiff In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
APIDiff is expected on this PR. Merging, since the CI passes with current changes. |
This change bumps controller-runtime to 0.15, k8s.io/* deps to 0.27.2 and kubebuilder to the commit hash that includes both of these controller-runtime and k8s.io upgrades.