-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update controller-runtime from 0.14 to 0.15 #6465
Conversation
c44093a
to
de06a67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bshephar Thanks for the PR. Updating controller-runtime in this specific case comes with bumping k8s too. The process usually involves the following steps:
- Updating c-r to the latest version in SDK binary, involving a bump in all its dependent libraries (operator-lib, o-f/api, k8s deps etc).
- Bumping all the plugins to include the latest versions of Kubebuilder and C-R.
- Bumping envtest to use the latest version of k8s.
Doing (1) and (2) together is usually easier. But since that still involves bumping c-r and k8s deps in all the other plugins, we could proceed with (1), but also make sure to complete (2) and rest to fully support the latest versions.
d5efe19
to
9ec0d43
Compare
Looks like we also need to update
https://github.com/kubernetes-sigs/kubebuilder/tree/master/pkg/plugins/common/kustomize |
Ok, so updating things in
|
a396413
to
60b1372
Compare
cc2cebe
to
186663c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bshephar I tried these locally. This change requires helm-operator-plugins (operator-framework/helm-operator-plugins#216) and java-plugins (https://github.com/operator-framework/java-operator-sdk) to be bumped first.
However, meanwhile just to test if openapi bump is causing problems, I removed both the plugin dependencies, bumped KB to v3.11.0 (https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v3.11.0) and tested locally. Looks like go mod tidy
works well, there are just some breaking changes which need to be addressed in the codebase. Considering this, I believe the error you are facing is because of both the plugins haven't been bumped their k8s dependencies yet. Could we merge both of them to proceed further? Thanks!
This change updates the version of controller-runtime to v0.15.0 along with the necessary method changes to satisfy the interface changes that come with v0.15.0. This is similar to what has been done in Kubebuilder here: https://github.com/kubernetes-sigs/kubebuilder/pull/3394/files The specific interface changes in this version are defined in this controller-runtime commit: kubernetes-sigs/controller-runtime@8770b4d#diff-0b6c79b3483fe5ad476ea26192f2d8bfe05a44688209721b626dc793204df28eR42 Signed-off-by: Brendan Shephard <bshephar@redhat.com>
Signed-off-by: Brendan Shephard <bshephar@redhat.com>
This change bumps the controller-runtime version to the commit hash that includes controller-runtime v0.15 Signed-off-by: Brendan Shephard <bshephar@redhat.com>
This change bumps the kubebuilder version to the commit hash that includes the controller-runtime v0.15 change. Signed-off-by: Brendan Shephard <bshephar@redhat.com>
186663c
to
50d6bc9
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change updates helm-operator-plugins and other dependencies associated with the CR v0.15.0 and k8s.io 0.27.2 Signed-off-by: Brendan Shephard <bshephar@redhat.com>
946c6b5
to
a60b07d
Compare
@bshephar Can we merge the work done here in this PR (#6514). If you're fine, we can collaborate on this and I can cherry pick some of the commits from your branch and add it to the other PR. This is because the other one includes changes in KB and other operators that need to fixed along with this. Also, we are blocked on one of the controller-runtime's PR to include logging to the event handler. |
Hey! Yeah, we sure can. I'm happy with that, I'll close this one. |
This change updates the version of controller-runtime to v0.15.0 along with the necessary method changes to satisfy the interface changes that come with v0.15.0. This is similar to what has been done in Kubebuilder here:
https://github.com/kubernetes-sigs/kubebuilder/pull/3394/files
The specific interface changes in this version are defined in this controller-runtime commit:
kubernetes-sigs/controller-runtime@8770b4d#diff-0b6c79b3483fe5ad476ea26192f2d8bfe05a44688209721b626dc793204df28eR42