Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests to confirm that registry+v1 bundles with with install mode other than AllNamespaces are not allowed #816

Closed
Tracked by #734
m1kola opened this issue May 2, 2024 · 3 comments

Comments

@m1kola
Copy link
Member

m1kola commented May 2, 2024

The relevant check is currently in rukpak, but I'm planning to add a test in operator-controller. This will help to ensure that we do not break the checks in the process of moving rukpak functionality into operator controller.

@m1kola
Copy link
Member Author

m1kola commented May 21, 2024

Blocked at the moment: we need to bump rukpak to be able to add this test because we need this fix, but bumping rukpak will break helm integration work.

@m1kola
Copy link
Member Author

m1kola commented Jun 12, 2024

No longer blocked, but I realised that rukapk validation allows more than we want at the moment. Created operator-framework/rukpak#913 to tighten the validation.

@m1kola
Copy link
Member Author

m1kola commented Jun 18, 2024

We decided not to do the tests in operator-controller and have this stuff tested in rukpak instead. I checked rukpak test coverage and added missing tests for both this limitation and for #815.

Test coverage was added in operator-framework/rukpak#922
And removed e2e coverage for for webhooks limitation from operator-controller in #946

I think we are done here. Closing.

@m1kola m1kola closed this as completed Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants