This repository has been archived by the owner on Aug 12, 2024. It is now read-only.
Add install mode validation #913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
New validation only allows AllNamespaces install mode to be used. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
force-pushed
the
only_allow_AllNamespaces_install_mod
branch
from
b64485c
to
1d411dd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
==========================================
+ Coverage 14.41% 14.61% +0.20%
==========================================
Files 41 41
Lines 2553 2552 -1
==========================================
+ Hits 368 373 +5
+ Misses 2128 2124 -4
+ Partials 57 55 -2 ☔ View full report in Codecov by Sentry. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Closing this for now as we try to keep convertor generic in case we want to support other install modes too. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New validation only allows
AllNamespacesinstall mode to be used.Related to operator-framework/operator-controller#816