Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The catalogd and operator-controller metrics services target each other #955

Closed
Tracked by #950
joelanford opened this issue Jun 18, 2024 · 4 comments
Closed
Tracked by #950

The catalogd and operator-controller metrics services target each other #955

joelanford opened this issue Jun 18, 2024 · 4 comments
Assignees
@LalatenduMohanty
Labels
kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1

Comments

@joelanford
Copy link
Member

The label selector used for both catalogd and operator-controller metrics services is: control-plane: controller-manager. Now that both catalogd and operator controller are running in the same namespace, that means both services target both pods.

This will lead to a confusing prometheus metrics collection. We need to do a sweep of labels and label selectors used in catalogd and operator controller to make sure we do not actually overlap.
@joelanford joelanford added kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1 labels Jun 18, 2024
@joelanford joelanford mentioned this issue Jun 18, 2024
Open
26 tasks
@LalatenduMohanty
Copy link
Member

/assign

@LalatenduMohanty
Copy link
Member

PR #969 sent to fix in this repo.

LalatenduMohanty added a commit to LalatenduMohanty/catalogd that referenced this issue Jun 25, 2024
@LalatenduMohanty
Fixing the labels for better identify metrics
1241103 
As the label selector used for both catalogd and operator-controller
metrics services is "control-plane: controller-manager". Hence changing
the labels in both operator-controller and catalogd to make sure we
do not overlap.
Refer
operator-framework/operator-controller#955 for
details

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty LalatenduMohanty mentioned this issue Jun 25, 2024
Merged
@LalatenduMohanty
Copy link
Member

PR for catalogd operator-framework/catalogd#292

github-merge-queue bot pushed a commit to operator-framework/catalogd that referenced this issue Jun 26, 2024
@LalatenduMohanty
Fixing the labels for better identify metrics (#292)
c0ed3fa 
As the label selector used for both catalogd and operator-controller
metrics services is "control-plane: controller-manager". Hence changing
the labels in both operator-controller and catalogd to make sure we
do not overlap.
Refer
operator-framework/operator-controller#955 for
details

Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
@LalatenduMohanty
Copy link
Member

#969 has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LalatenduMohanty LalatenduMohanty

Labels
kind/bug Categorizes issue or PR as related to a bug. v1.0 Issues related to the initial stable release of OLMv1
Projects
OLM v1
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelanford @LalatenduMohanty