🐛 Fixing the labels for better metrics collection #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the label selector used for both catalogd and operator-controller metrics services is "control-plane: controller-manager". Hence changing the labels in both operator-controller and catalogd to make sure we do not overlap. Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
=======================================
Coverage 79.40% 79.40%
=======================================
Files 17 17
Lines 1170 1170
=======================================
Hits 929 929
Misses 165 165
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LalatenduMohanty
changed the title
LalatenduMohanty
changed the title
joelanford
reviewed
Jun 26, 2024
| @@ -2,7 +2,7 @@ apiVersion: v1 | |||
| kind: Namespace | |||
| metadata: | |||
| labels: | |||
| control-plane: controller-manager | |||
| control-plane: operator-controller-controller-manager | |||
There was a problem hiding this comment.
I think I would delete this label from the namespace. catalogd contributes this same namespace in it's manifest, which means we'll end up with conflicts or silent overwrites.
This is related to #967
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the label selector used for both catalogd and operator-controller metrics services is "control-plane: controller-manager". Hence changing the labels in both operator-controller and catalogd to make sure we do not overlap.
Description
Reviewer Checklist