🐛 Set correct labels on helm release during upgrade #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write the correct label set to the helm release. This commit fixes an issue where the upgrades get wedged after the first upgrade when following legacy upgade semantics because the resolver relied on inaccurate version data in the helm release label Signed-off-by: kevinrizza <krizza@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1017 +/- ##
==========================================
- Coverage 78.07% 78.05% -0.02%
==========================================
Files 18 18
Lines 1254 1253 -1
==========================================
- Hits 979 978 -1
Misses 193 193
Partials 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joelanford
changed the title
joelanford
approved these changes
Jul 8, 2024
Merged
via the queue into
operator-framework:main
with commit Jul 8, 2024
235e3d4
17 of 19 checks passed
perdasilva
pushed a commit
to LalatenduMohanty/operator-controller
that referenced
this pull request
Aug 13, 2024
…#1017) Write the correct label set to the helm release. This commit fixes an issue where the upgrades get wedged after the first upgrade when following legacy upgade semantics because the resolver relied on inaccurate version data in the helm release label Signed-off-by: kevinrizza <krizza@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write the correct label set to the helm release. This commit fixes an issue where the upgrades get wedged after the first upgrade when following legacy upgade semantics because the resolver relied on inaccurate version data in the helm release label
Resolves #1009
Description
Reviewer Checklist