-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds new Status condition "Resolved" and related status field "resolvedBundleResource" to Operator CR #213
Adds new Status condition "Resolved" and related status field "resolvedBundleResource" to Operator CR #213
Conversation
50dd855
to
f28c545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
But tests are failing.
api/v1alpha1/operator_types.go
Outdated
|
||
ReasonInstallationSucceeded = "InstallationSucceeded" | ||
ReasonResolutionFailed = "ResolutionFailed" | ||
ReasonResolutionUnknown = "ResolutionUnknown" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: these ought to be alphabetical, but others are not. :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
This commits adds a new status conditions: "Resolved" that represent if the Operator-Controller was able to resolv the desired operator image or not. Also, extends the status with a new field: "resolvedBundleResource" that contains the resolved operator image. Signed-off-by: Joaquim Moreno Prusi <joaquim@redhat.com>
Signed-off-by: Joaquim Moreno Prusi <joaquim@redhat.com>
f28c545
to
c6a638a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Still looks good to me. Merging since it's kinda-sorta blocking #201 |
Description
This PR extends the status conditions of the Operator CR and adds a new status field.
Fixes #202
Reviewer Checklist