Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing or re-defining the meaning of the existing Ready condition. #201

Closed
Tracked by #183
awgreene opened this issue May 9, 2023 · 6 comments · Fixed by #217
Closed
Tracked by #183

Removing or re-defining the meaning of the existing Ready condition. #201

awgreene opened this issue May 9, 2023 · 6 comments · Fixed by #217
Assignees
@tmshort
Labels
olm-v1/m4
Milestone
v0.2.0

Comments

@awgreene
Copy link
Member

awgreene commented May 9, 2023 •
edited
Loading

The installed condition proposed in #199 basically replaces the existing "Ready" condition. This ticket tracks the need to remove the existing "Ready" condition.
@awgreene awgreene mentioned this issue May 9, 2023
Closed
4 tasks
@joelanford
Copy link
Member

Related: #126

@tmshort tmshort self-assigned this May 10, 2023
@tmshort tmshort mentioned this issue May 16, 2023
Merged
4 tasks
@tmshort
Copy link
Contributor

tmshort commented May 16, 2023

At this point is this a removal? Considering #199 and #202?

@joelanford
Copy link
Member

For now removal seems reasonable. The alternative (if we want Ready to be a rollup of other status) is Ready == Installed=True + Resolved=True + installedSource == resolvedSource.

@tmshort
Copy link
Contributor

tmshort commented May 16, 2023

A rollup would not be orthogonal... so probably not.

@joelanford
Copy link
Member

Agreed. I think removal of Ready is fine if we have Installed and Resolved. As another follow-on, it would also be nice to have Progressing, somewhat as described in #126 (which would conceptually be "trying to get to installedSource == resolvedSource" or "i give up, my inputs need to change")

@tmshort
Copy link
Contributor

tmshort commented May 17, 2023

I might be able to get #126 in, maybe? But the delete work is done.

tmshort added a commit to tmshort/operator-controller that referenced this issue May 18, 2023
@tmshort
Remove TypeReady Condition
52b7626 
Fixes operator-framework#201

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort mentioned this issue May 18, 2023
Merged
4 tasks
tmshort added a commit that referenced this issue May 19, 2023
@tmshort
Remove TypeReady Condition
7929907 
Fixes #201

Signed-off-by: Todd Short <tshort@redhat.com>
@awgreene awgreene added this to the v0.2.0 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmshort tmshort

Labels
olm-v1/m4
Projects
OLM V1
Archived in project
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Remove TypeReady Condition tmshort/operator-controller
3 participants
@joelanford @awgreene @tmshort