Remove TypeReady Condition #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes operator-framework#201 Signed-off-by: Todd Short <tshort@redhat.com>
|
Yes, this is a breaking API change (so ignore |
ncdc
approved these changes
May 18, 2023
m1kola
approved these changes
May 18, 2023
| Message: err.Error(), | ||
| ObservedGeneration: op.GetGeneration(), | ||
| }) | ||
| // originally Reason: operatorsv1alpha1.ReasonInstallationFailed |
There was a problem hiding this comment.
Are we going to replace this with some other conditions? Where are we tracking this?
There was a problem hiding this comment.
Yes, it's being tracked by #199.
There was a problem hiding this comment.
The comment isn't necessary, I can probably remove it, but I was also thinking of the "Progressing" Condition listed in #126, but decided to keep this one simple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #201
Description
This is being replaced with other conditions.
Reviewer Checklist