Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator CR Installed status condition #218

Merged

Conversation

jmprusi
Copy link
Member

@jmprusi jmprusi commented May 18, 2023

Description

This PR extends the operator CR with a new condition: "Installed" which exposes the bundle deployment status at the operator CR level.

It also adds a new field: "installedBundleResource" that contains the installed image/git ref.

Closes #199

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 20, 2023
This commits adds a new status condition to the operator CR: "Installed" that represent if
the bundledeployment was able to install the desired operator ot not.

Also, extends the status with a new field: "InstalledBundleSource" that
contains the installed operator image/git reference

Signed-off-by: Joaquim Moreno Prusi <joaquim@redhat.com>
@jmprusi jmprusi force-pushed the jmprusi/199-installedBundleSource branch from e012458 to b15622a Compare May 22, 2023 09:27
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 22, 2023
Signed-off-by: Joaquim Moreno Prusi <joaquim@redhat.com>
@jmprusi jmprusi force-pushed the jmprusi/199-installedBundleSource branch from b15622a to 8d06a34 Compare May 22, 2023 10:13
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, just some nits:

api/v1alpha1/operator_types.go Outdated Show resolved Hide resolved
controllers/operator_controller.go Show resolved Hide resolved
Signed-off-by: Joaquim Moreno Prusi <joaquim@redhat.com>
@jmprusi jmprusi force-pushed the jmprusi/199-installedBundleSource branch from 2ed1ea0 to abf19f5 Compare May 23, 2023 09:21
@tmshort tmshort merged commit 4186ffb into operator-framework:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add status.installedBundleSource
4 participants