Clean-up of operator conditions with helper funcs #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs a rebase after merging #218. |
Signed-off-by: Joaquim Moreno Prusi <joaquim@redhat.com>
jmprusi
force-pushed
the
jmprusi/condition-helpers
branch
from
13f8591
to
665288a
Compare
fixed! |
tmshort
approved these changes
May 23, 2023
|
@tmshort thanks! Can you please attach this one to the OLM v1 and v0.2.0 milestone? I can't do it myself. |
|
This is not an issue... |
|
Yeah, looks as though it need to be an issue to be viewed in the milestones. |
|
@tmshort You should be able to manually set the milestone on this PR to show up in the v0.2.0 release milestone. I don't think the OLMv1 GH project is configured to show PRs (I think they can be configured to show PRs) |
|
@everettraven right, I can set the label, but it won't show it under M4... but it looks as though it's showing up under v0.2.0...? |
|
(It would also help if I look just under the labels... D'Oh) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean-up of operator conditions with helper funcs.
Requires #218
follow-up of #218 (comment)
Reviewer Checklist