Fixes kind cluster cleanup in e2e make target
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Currently we have `kind-cluster-cleanup` as a dependency in `kind-cluster` target. Since `make` only builds a target once this means that `e2e` target performs cleanup before creating a new cluster and skips cleanup at the end leaving cluster hanging around. With this change, `make e2e` will be failing on cluster creation, if a cluster with the same name already exists, but the failure message will clearly indicate the issue. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
force-pushed
the
makefile-fixup-kind-cluster-cleanup
branch
from
dfc8b3d
to
051cb1c
Compare
Codecov Report
@@ Coverage Diff @@
## main #298 +/- ##
=======================================
Coverage 77.00% 77.00%
=======================================
Files 15 15
Lines 687 687
=======================================
Hits 529 529
Misses 129 129
Partials 29 29 |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ncdc
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently we have
kind-cluster-cleanupas a dependency inkind-clustertarget. Sincemakeonly builds a target once this means thate2etarget performs cleanup before creating a new cluster and skips cleanup at the end leaving cluster hanging around.With this change,
make e2ewill be failing on cluster creation, if a cluster with the same name already exists, but the failure message will clearly indicate the issue.Reviewer Checklist