Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ginkgo from resolution/variables unit tests #402

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Sep 7, 2023

Fixes #195

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Fixes operator-framework#195

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort requested a review from a team as a code owner September 7, 2023 20:13
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (23d0386) 81.64% compared to head (88bab66) 81.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #402   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files          21       21           
  Lines         937      937           
=======================================
  Hits          765      765           
  Misses        119      119           
  Partials       53       53           
Flag Coverage Δ
e2e 61.79% <ø> (ø)
unit 77.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Member

@awgreene awgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work
/approve

@tmshort tmshort added this pull request to the merge queue Sep 7, 2023
Merged via the queue into operator-framework:main with commit 8de87b9 Sep 7, 2023
12 checks passed
@tmshort tmshort deleted the test-variables branch September 8, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update resolution/variables package tests
2 participants