Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update resolution/variables package tests #195

Closed
2 tasks
Tracked by #189
perdasilva opened this issue May 9, 2023 · 0 comments · Fixed by #402
Closed
2 tasks
Tracked by #189

Update resolution/variables package tests #195

perdasilva opened this issue May 9, 2023 · 0 comments · Fixed by #402
Assignees
@tmshort
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@perdasilva
Copy link
Contributor

perdasilva commented May 9, 2023 •
edited by tmshort
Loading

Description

Follow the testing guidelines set forth in #188 and refactor the resolution/variables package unit tests.

Pre-Conditions

Acceptance Criteria
@perdasilva perdasilva mentioned this issue May 9, 2023
Closed
8 tasks
@perdasilva perdasilva added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 9, 2023
@perdasilva perdasilva changed the title update olm variable source tests Update olm variable source tests May 9, 2023
@tmshort tmshort changed the title Update olm variable source tests Update resolution/variables tests Sep 7, 2023
@tmshort tmshort changed the title Update resolution/variables tests Update resolution/variables package tests Sep 7, 2023
@tmshort tmshort self-assigned this Sep 7, 2023
tmshort added a commit to tmshort/operator-controller that referenced this issue Sep 7, 2023
@tmshort
Remove ginkgo from resolution/variables unit tests
88bab66 
Fixes operator-framework#195

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort mentioned this issue Sep 7, 2023
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Sep 7, 2023
@tmshort
Remove ginkgo from resolution/variables unit tests (#402)
8de87b9 
Fixes #195

Signed-off-by: Todd Short <tshort@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmshort tmshort

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
OLM V1
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ginkgo from resolution/variables unit tests tmshort/operator-controller
2 participants
@perdasilva @tmshort