Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Epic] Refactor ginkgo unit tests to go test #189

Closed
8 tasks done
perdasilva opened this issue May 9, 2023 · 2 comments
Closed
8 tasks done

[Epic] Refactor ginkgo unit tests to go test #189

perdasilva opened this issue May 9, 2023 · 2 comments
Labels
epic good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@perdasilva
Copy link
Contributor

perdasilva commented May 9, 2023 •
edited
Loading

Description

In discussion #168, we've decided to avoid using ginkgo for unit testing. We need to move our current ginkgo unit tests to go test.

Tasks
@perdasilva perdasilva added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 9, 2023
@m1kola m1kola mentioned this issue Jun 26, 2023
Merged
4 tasks
tmshort added a commit to tmshort/operator-controller that referenced this issue Sep 6, 2023
@tmshort
Remove ginkgo from api tests
1702b3f 
This is related to epic operator-framework#189, although there doesn't seem to be a related
issue for this directory.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort mentioned this issue Sep 6, 2023
Merged
4 tasks
tmshort added a commit to tmshort/operator-controller that referenced this issue Sep 7, 2023
@tmshort
Remove ginkgo from api tests
5453883 
This is related to epic operator-framework#189, although there doesn't seem to be a related
issue for this directory.

Signed-off-by: Todd Short <tshort@redhat.com>
tmshort added a commit to tmshort/operator-controller that referenced this issue Sep 7, 2023
@tmshort
Remove ginkgo from api tests
669bd49 
This is related to epic operator-framework#189, although there doesn't seem to be a related
issue for this directory.

Signed-off-by: Todd Short <tshort@redhat.com>
tmshort added a commit to tmshort/operator-controller that referenced this issue Sep 7, 2023
@tmshort
Remove ginkgo from api tests
81633b6 
This is related to epic operator-framework#189, although there doesn't seem to be a related
issue for this directory.

Signed-off-by: Todd Short <tshort@redhat.com>
tmshort added a commit to tmshort/operator-controller that referenced this issue Sep 7, 2023
@tmshort
Remove ginkgo from api tests
168b05d 
This is related to epic operator-framework#189, although there doesn't seem to be a related
issue for this directory.

Signed-off-by: Todd Short <tshort@redhat.com>
github-merge-queue bot pushed a commit that referenced this issue Sep 7, 2023
@tmshort
Remove ginkgo from api tests (#399)
1ec4a23 
This is related to epic #189, although there doesn't seem to be a related
issue for this directory.

Signed-off-by: Todd Short <tshort@redhat.com>
@m1kola
Copy link
Member

m1kola commented Sep 8, 2023

Probably worth leaving tests related to any of the following folders/files alone:

  • internal/resolution/entities
  • internal/resolution/entitysources
  • internal/resolution/util/predicates
  • internal/resolution/util/sort (most likely)
  • cmd/resolutioncli/entity_source.go

We are going to remove entity sources soon-ish (#347) and we already have tests which does not use ginkgo in the package which is going to replace the above. See draft PR #393 for details.

@m1kola m1kola mentioned this issue Oct 19, 2023
Merged
4 tasks
@tmshort
Copy link
Contributor

tmshort commented Nov 29, 2023

With the latest set of commits, operator-controller is now ginkgo free!

@tmshort tmshort closed this as completed Nov 29, 2023
@m1kola m1kola mentioned this issue Dec 1, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
OLM V1
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@m1kola @joelanford @perdasilva @tmshort