Operator update tests with semver and legacy upgrade constraints
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
4 tasks
m1kola
changed the title
Operator update tests with semver and legacy upgrade constraints
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 83.64% 83.64%
=======================================
Files 23 23
Lines 862 862
=======================================
Hits 721 721
Misses 96 96
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
m1kola
commented
Oct 19, 2023
m1kola
force-pushed
the
upgrade_tests
branch
2 times, most recently
from
639bca5
to
dd5096b
Compare
m1kola
commented
Oct 19, 2023
m1kola
force-pushed
the
upgrade_tests
branch
2 times, most recently
from
da2223b
to
4028ae4
Compare
New test data is going be easier to use with semver upgrades. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
commented
Oct 20, 2023
| @@ -165,10 +170,10 @@ var _ = Describe("Operator Controller Test", func() { | |||
| Expect(bd.Spec.Template.Spec.ProvisionerClassName).To(Equal("core-rukpak-io-registry")) | |||
| Expect(bd.Spec.Template.Spec.Source.Type).To(Equal(rukpakv1alpha1.SourceTypeImage)) | |||
| Expect(bd.Spec.Template.Spec.Source.Image).NotTo(BeNil()) | |||
| Expect(bd.Spec.Template.Spec.Source.Image.Ref).To(Equal("quay.io/operatorhubio/prometheus@sha256:5b04c49d8d3eff6a338b56ec90bdf491d501fe301c9cdfb740e5bff6769a21ed")) | |||
| Expect(bd.Spec.Template.Spec.Source.Image.Ref).To(Equal("quay.io/operatorhubio/prometheus@fake2.0.0")) | |||
There was a problem hiding this comment.
I changed test data (included more packages with higher versions). There is a bunch of tests where we test installing packages without a specific version and the behaviour is to select the latest version. So I had to update the assertions to reflect the latest version.
Changes to the test data & updates to assertions are in separate commit. Reviewing commit-by commit might be more convinient for some.
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
OperatorReconcilerreconcile tests forOperatorupgrades. Tests include:Closes #468
Reviewer Checklist