Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update controllers/validators package tests #193

Closed
2 tasks
Tracked by #189
perdasilva opened this issue May 9, 2023 · 0 comments · Fixed by #542
Closed
2 tasks
Tracked by #189

Update controllers/validators package tests #193

perdasilva opened this issue May 9, 2023 · 0 comments · Fixed by #542
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@perdasilva
Copy link
Contributor

perdasilva commented May 9, 2023 •
edited by tmshort
Loading

Description

Follow the testing guidelines set forth in #188 and refactor the controllers/validators package unit tests.

Pre-Conditions

Acceptance Criteria
@perdasilva perdasilva mentioned this issue May 9, 2023
Closed
8 tasks
@perdasilva perdasilva changed the title update crd constraints variable source tests Update crd constraints variable source tests May 9, 2023
@perdasilva perdasilva added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 9, 2023
@tmshort tmshort changed the title Update crd constraints variable source tests Update controllers/validators source tests Sep 7, 2023
@tmshort tmshort changed the title Update controllers/validators source tests Update controllers/validators package tests Sep 7, 2023
tmshort added a commit to tmshort/operator-controller that referenced this issue Nov 14, 2023
@tmshort
Remove ginkgo from internal/controller/validators
15be505 
Fix operator-framework#193

Added additional semver tests and converted to a table.

Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort tmshort mentioned this issue Nov 14, 2023
Merged
4 tasks
tmshort added a commit to tmshort/operator-controller that referenced this issue Nov 14, 2023
@tmshort
Remove ginkgo from internal/controller/validators
1e4e08b 
Fix operator-framework#193

Added additional semver tests, and converted to a table.

Signed-off-by: Todd Short <tshort@redhat.com>
tmshort added a commit to tmshort/operator-controller that referenced this issue Nov 15, 2023
@tmshort
Remove ginkgo from internal/controller/validators
ae90ea1 
Fix operator-framework#193

Added additional semver tests, and converted to a table.

Signed-off-by: Todd Short <tshort@redhat.com>
github-merge-queue bot pushed a commit that referenced this issue Nov 15, 2023
@tmshort
Remove ginkgo from internal/controller/validators (#542)
b55d472 
Fix #193

Added additional semver tests, and converted to a table.

Signed-off-by: Todd Short <tshort@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
OLM V1
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Remove ginkgo from internal/controller/validators tmshort/operator-controller
1 participant
@perdasilva