Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove ginkgo from internal/controller/validators #542

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Nov 14, 2023

Fix #193

Added additional semver tests and converted to a table.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner November 14, 2023 16:32
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6cb56f7) 78.59% compared to head (ae90ea1) 83.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #542      +/-   ##
==========================================
+ Coverage   78.59%   83.69%   +5.10%     
==========================================
  Files          18       20       +2     
  Lines         766      822      +56     
==========================================
+ Hits          602      688      +86     
+ Misses        131       92      -39     
- Partials       33       42       +9     
Flag Coverage Δ
e2e 63.86% <ø> (?)
unit 78.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fix operator-framework#193

Added additional semver tests, and converted to a table.

Signed-off-by: Todd Short <tshort@redhat.com>
@stevekuznetsov stevekuznetsov added this pull request to the merge queue Nov 15, 2023
Merged via the queue into operator-framework:main with commit b55d472 Nov 15, 2023
15 checks passed
@tmshort tmshort deleted the test-validators branch November 16, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update controllers/validators package tests
2 participants