🌱 Part 3: Reduce number of variable sources. Installed packages

[m1kola]

Description

Spliting #460 into smaller chunks. Related to #437

In this part I extract code related to creating installed package variables from InstalledPackageVariableSource and BundleDeploymentVariableSource into a separate function.

InstalledPackageVariableSource gets removed in this PR. BundleDeploymentVariableSource will be removed later in #501

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[m1kola]

Will keep in draft for now. I think "[FAIL] Operator Install when An operator is installed from an operator catalog [It] resolves again when a new catalog is available" failure is a legit one. From a quick look I do not see what is causing it.

Everything else seems to be a result of it (looks like some dependency between e2e tests).

[m1kola]

Will keep in draft for now. I think "[FAIL] Operator Install when An operator is installed from an operator catalog [It] resolves again when a new catalog is available" failure is a legit one. From a quick look I do not see what is causing it.

it was legit issue: I was doing things in incorrect order in BundleDeploymentVariableSource. Fixed now.

Everything else seems to be a result of it (looks like some dependency between e2e tests).

Created an issue for this: #512

[ncdc]

@joelanford any other comments?

[codecov]

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (55d54ab) 84.41% compared to head (cd784a0) 84.24%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   84.41%   84.24%   -0.18%     
==========================================
  Files          23       23              
  Lines         892      895       +3     
==========================================
+ Hits          753      754       +1     
- Misses         95       96       +1     
- Partials       44       45       +1     

Flag	Coverage Δ
e2e	65.69% <58.33%> (-0.23%)	⬇️
unit	79.14% <63.88%> (-0.41%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...al/resolution/variablesources/bundle_deployment.go	100.00% <100.00%> (+21.05%)	⬆️
...al/resolution/variablesources/installed_package.go	65.38% <59.25%> (-8.53%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.