馃尡 Add kapp-controller to Makefile to be installed with "run" command. #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtfranz
force-pushed
the
kapp-makefile
branch
from
493365f
to
3bbe0a5
Compare
Signed-off-by: dtfranz <dfranz@redhat.com>
dtfranz
force-pushed
the
kapp-makefile
branch
from
3bbe0a5
to
2913ff2
Compare
tmshort
reviewed
Feb 26, 2024
| @@ -6,6 +6,7 @@ export IMAGE_REPO ?= quay.io/operator-framework/operator-controller | |||
| export IMAGE_TAG ?= devel | |||
| export CERT_MGR_VERSION ?= v1.9.0 | |||
| export CATALOGD_VERSION ?= $(shell go list -mod=mod -m -f "{{.Version}}" github.com/operator-framework/catalogd) | |||
| export KAPP_VERSION ?= v0.50.0# TODO replace with above or below line to pull version from go.mod | |||
There was a problem hiding this comment.
Why does this look wrong? i.e. no space before #?
There was a problem hiding this comment.
I initially had the space there but if a space is left behind the comment then it gets pulled into the variable XD
tmshort
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds kapp-controller to the install script and pins version to
v0.50.0. Left a comment to note that once we addkapptogo.modwe can retrieve the version from there, so we have the version in just one place.Closes #609