✨ ADD scheme package for AddToScheme

[acmenezes]

Description

This PR adds a scheme package providing a central location for new apis to be added to scheme.

Also replaces the use of a new scheme instance and var by importing the package scheme and using scheme.Scheme.

Solves #322

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	b70e6ed
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/662aabf464a1e10008cb48a7
😎 Deploy Preview	https://deploy-preview-770--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[acmenezes]

Hi @m1kola , I'm not sure if this is what you expected when you opened the issue #322. I'm just starting getting acquainted with the code base you have here. I didn't catch a few lines here not sure exactly how they are being used.

[perdasilva]

lgtm

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.21%. Comparing base (265d60d) to head (b70e6ed).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #770      +/-   ##
==========================================
+ Coverage   67.16%   67.21%   +0.04%     
==========================================
  Files          22       23       +1     
  Lines        1465     1467       +2     
==========================================
+ Hits          984      986       +2     
  Misses        415      415              
  Partials       66       66              

Flag	Coverage Δ
e2e	45.53% <100.00%> (+0.07%)	⬆️
unit	61.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[m1kola]

That's what I had in mind, thanks for looking into it.

It looks like imports need to be sorted and we should be good to go.

I didn't catch a few lines here not sure exactly how they are being used.

I think it is dead code. We can probably just remove it.

[acmenezes]

That's what I had in mind, thanks for looking into it.

It looks like imports need to be sorted and we should be good to go.

I didn't catch a few lines here not sure exactly how they are being used.

I think it is dead code. We can probably just remove it.

Hi @m1kola , I remove those few lines but I saw some linting errors from a tool called gci but I couldn't determine what version you use to lint the project. Could point me to the right github repo? Then I can run it and do a clean up in order to merge the code. Thanks!

[acmenezes]

Hi @m1kola , I remove those few lines but I saw some linting errors from a tool called gci but I couldn't determine what version you use to lint the project. Could point me to the right github repo? Then I can run it and do a clean up in order to merge the code. Thanks!

Never mind actually. I figured it out. Bingo! It's fixed now. I believe we're good to go. Thanks.

[m1kola]

Looks good. Thanks you!

Never mind actually. I figured it out. Bingo!

Great! Take a look at make help - our Makefile has some useful commands for development. Like make run will spin up a Kind cluster with all the required components installed + will compile operator-controller from local source code and deploy it as well.

If you have any questions about development process - don't hesitate to ask on issues/PR or on Kubernetes slack (channel #olm-dev).

[m1kola]

Trying to merge again. I think I introduced a flake in #785 and that's why e2e failed in merge queue.

[acmenezes]

Looks good. Thanks you!

Never mind actually. I figured it out. Bingo!

Great! Take a look at make help - our Makefile has some useful commands for development. Like make run will spin up a Kind cluster with all the required components installed + will compile operator-controller from local source code and deploy it as well.

If you have any questions about development process - don't hesitate to ask on issues/PR or on Kubernetes slack (channel #olm-dev).

Thanks @m1kola !