Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Enable admissionregistration.k8s.io/v1beta1 #771

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Apr 22, 2024

Description

We will be using validating admission policy API for a few things (like #736) and enforcing package uniqueness on ClusterExtension).

This PR enables admissionregistration.k8s.io/v1beta1 in kind cluster used for E2E and local development.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2024
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 48690ae
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/66264f343177cd0007883264
😎 Deploy Preview https://deploy-preview-771--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.90%. Comparing base (9785be8) to head (48690ae).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #771   +/-   ##
=======================================
  Coverage   67.90%   67.90%           
=======================================
  Files          22       22           
  Lines        1424     1424           
=======================================
  Hits          967      967           
  Misses        391      391           
  Partials       66       66           
Flag Coverage Δ
e2e 46.34% <ø> (ø)
unit 61.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola marked this pull request as ready for review April 22, 2024 12:05
@m1kola m1kola requested a review from a team as a code owner April 22, 2024 12:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2024
@everettraven everettraven added this pull request to the merge queue Apr 22, 2024
Merged via the queue into operator-framework:main with commit 652e4bc Apr 22, 2024
16 checks passed
@m1kola m1kola deleted the kind_enable_admissionregistration_beta_api branch April 22, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants