🌱 GitHub Actions: Setup kind cluster without ctlptl

[m1kola]

Description

We already have kind cluster setup scripted in Makefile which includes correct configuration.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	5e840e9
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/6627802e6098980008e731dd
😎 Deploy Preview	https://deploy-preview-777--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.16%. Comparing base (0c41e3e) to head (5e840e9).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #777   +/-   ##
=======================================
  Coverage   67.16%   67.16%           
=======================================
  Files          22       22           
  Lines        1465     1465           
=======================================
  Hits          984      984           
  Misses        415      415           
  Partials       66       66           

Flag	Coverage Δ
e2e	45.46% <ø> (ø)
unit	61.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[joelanford]

I recall there being a specific reason for using ctlptl. It may have been the ease of getting an image registry setup to test pulling private catalog images.

On the other hand, all the tests are passing with this change, so 🤷‍♂️

@everettraven May have more specific knowledge.

[tmshort]

This job (tilt) appears to be failing in #774... but do we really need to change the tilt code, or is it something about that PR?

[m1kola]

@tmshort this PR will fix tilt for #774. The reason for the failure is that ctlptl creates a kind cluster with default config, but we need a custom config to enable beta APIs. I added a kind config in #771 but I missed ctlptl: I made an assumption that all clusters in CI are being created with our Makefile targets.

[m1kola]

I recall there being a specific reason for using ctlptl. It may have been the ease of getting an image registry setup to test pulling private catalog images.

We discussed this in upstream slack here. I think this was related to e2e jobs. I don't think the tilt job is actually testing anything beyond being able to build and deploy the binaries with tilt. It does not use registry with test bundle images as far as I understand.