-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.1] Bug 1753394: include git sha in ART builds #1044
[release-4.1] Bug 1753394: include git sha in ART builds #1044
Conversation
ART sets SOURCE_GIT_COMMIT env variable in Dockerfile at build time. - If SOURCE_GIT_COMMIT is set use its value, otherwise get the commit sha from current HEAD. https://jira.coreos.com/browse/OLM-1182 https://bugzilla.redhat.com/show_bug.cgi?id=1662263 https://jira.coreos.com/browse/ART-460
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1662263, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1753394, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/assign @tkashem |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1753394 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #961
/assign ecordell