Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1662263: include git sha in ART builds #961

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

tkashem
Copy link
Collaborator

@tkashem tkashem commented Jul 23, 2019

ART sets SOURCE_GIT_COMMIT env variable in Dockerfile at build time.

  • If SOURCE_GIT_COMMIT is set use its value, otherwise get the
    commit sha from current HEAD.

https://jira.coreos.com/browse/OLM-1182
https://jira.coreos.com/browse/ART-460

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1662263

ART sets SOURCE_GIT_COMMIT env variable in Dockerfile at build time.
- If SOURCE_GIT_COMMIT is set use its value, otherwise get the
  commit sha from current HEAD.

https://jira.coreos.com/browse/OLM-1182
https://bugzilla.redhat.com/show_bug.cgi?id=1662263
https://jira.coreos.com/browse/ART-460
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 23, 2019
@ecordell
Copy link
Member

/lgtm

@ecordell ecordell changed the title bz-1662263: include git sha in ART builds Bug 1662263: include git sha in ART builds Jul 23, 2019
@openshift-ci-robot
Copy link
Collaborator

@tkashem: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1662263: include git sha in ART builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 23, 2019
@ecordell
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 24, 2019
@ecordell
Copy link
Member

/approve

@dinhxuanvu
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, ecordell, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tkashem
Copy link
Collaborator Author

tkashem commented Jul 26, 2019

/test e2e-aws-olm

@ecordell
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 94aeafd into operator-framework:master Jul 26, 2019
@openshift-ci-robot
Copy link
Collaborator

@tkashem: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1662263: include git sha in ART builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Member

/cherry-pick release-4.1

@openshift-cherrypick-robot

@ecordell: new pull request created: #1044

In response to this:

/cherry-pick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants