feat(resolver): use provided and required apis from grpc #1101
Conversation
openshift-ci-robot
added
do-not-merge/hold
go.mod
Outdated
| @@ -54,6 +52,8 @@ replace ( | |||
| github.com/openshift/api => github.com/openshift/api v3.9.1-0.20190924102528-32369d4db2ad+incompatible | |||
| github.com/openshift/client-go => github.com/openshift/client-go v0.0.0-20190923180330-3b6373338c9b | |||
|
|
|||
| github.com/operator-framework/operator-registry => ../operator-registry | |||
ecordell
force-pushed
the
resolver-required-apis
branch
from
8ed2e64 to
e0ef09d
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
5 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
|
/retest |
calculating from the csv
ecordell
force-pushed
the
resolver-required-apis
branch
from
e0ef09d to
25901bc
Compare
|
/retest |
|
/lgtm |
|
/retest |
|
/lgtm |
|
@ecordell: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
ecordell
force-pushed
the
resolver-required-apis
branch
from
c465add to
25901bc
Compare
|
@ecordell: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ecordell, jpeeler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This is passing all tests but gcp, which seems to broken everywhere. Merging manually. |
Description of the change:
This uses the required/provided apis from the registry api response to do dependency resolution.
The change itself is fairly small, but the diff is slightly larger because I switched the resolver to work directly with the api objects instead of the bundle abstraction (which is less useful if we don't unpack/cache the contents).
Motivation for the change:
Previously, dependency information was extracted from CSVs that were included in the registry response. With bundle images, we will not always have the CSV available.
Instead, the registry extracts this information (it was already extracting provided apis) and sends it as part of the bundle response. OLM trusts this response to know which operators to resolve.
Reviewer Checklist
/docs